In our support boards we aim to provide support for the B3 core in its current state. Older releases of B3 are NOT supported. Check our front page for the latest version. You may post feature requests in our General Discussion board. Modifications and Hacks of the core B3 code are NOT supported.
Before you ask for support: [ Read the Support Instructions ] - More info: [ Full Support Disclaimer ]

You are here: Big Brother Bot ForumSupport ForumsGeneral Usage Support (Moderator: MordyT)Getting !restart to work [patch]
Pages: [1]   Go Down
« previous next »
  Print  
Author Topic: Getting !restart to work [patch]  (Read 776 times) Bookmark and Share
arbscht
Newbie
*
Posts: 1
Offline Offline
« on: April 28, 2009, 11:18:10 AM »
Hi,

I admin several servers using B3, and the issue with !restart failing has been biting us.  Rather than disabling it entirely, I figured it would be worth fixing.  I've patched our B3 installation to get it working with the existing autorestart framework that run.py provides.

Essentially, the problem is that the teardown routines in parser.py occur without co-ordination in two parallel threads.  One finishes before the other has a chance, and wouldn't have checked its exit status anyway.  This patch gets the main thread to wait for the handler thread to finish, and to repeat its exit status so that run.py knows what happened.

The patch is against a recent git HEAD (ThorN's repo).

I'm not sure what protocol you have for submitting patches, so I'm posting it here for review.  Let me know if I should post it elsewhere.

Thanks

[attachment deleted by maintenance - older than 60 days]
« Last Edit: April 28, 2009, 12:07:55 PM by arbscht » Logged
xlr8or
[ www.xlrstats.com ]
Project Lead
*
OS: Linux
Type: Owner dedicated server(s)
Gameservers: CoD, CoD2, CoD5, UrT
Posts: 2022
Offline Offline
WWW
Support Specialty: B3-Core, CoD/UrT/WoP/ETPro parsers, Plugin development
« Reply #1 on: April 30, 2009, 11:42:22 PM »
Looks like a good patch afaik. I will test it on my repo (Thorn's repo is way behind).

Maybe you can send me a pull request on github so I know which fork this patch is in.
Logged

Github repo - Groupware
xlr8or
[ www.xlrstats.com ]
Project Lead
*
OS: Linux
Type: Owner dedicated server(s)
Gameservers: CoD, CoD2, CoD5, UrT
Posts: 2022
Offline Offline
WWW
Support Specialty: B3-Core, CoD/UrT/WoP/ETPro parsers, Plugin development
« Reply #2 on: May 10, 2009, 02:12:02 AM »
The patch is applied to the dev repo. Thanks for your contribution!
Logged

Github repo - Groupware
Tags:
Pages: [1]   Go Up
  Print  
« previous next »
 
Jump to:  


Rate this page +1 at Google Search


SimplePortal 2.3.1 © 2008-2009, SimplePortal