next »

[Garreth]

I've recently noticed that you can't use "@" (at) symbol in your username or password in database or ftp connections. Quickfix is just not use this symbol, but for some people it might be more serious issue.

For example, my webhosting where I store bbb database and status.xml, forces ftp username in the form: "something@hostname.pl", so in status.xml I had to enter:
<set name="output_file">http://ftp://something@hostname.pl:password@ftp_address/status.xml</set>
which was wrongly parsed. I had to modify status.py, because I couldn't change the username.

Moreover, for keeping high security, I use random password generators. In obtained passwords I have to replace "@" to different character, because of BBB.

Is there any way of entering such password/usernames without modifying source files, or it needs a more serious fix?

[MordyT]

Seconded. I can't tell you how many times I have had to ask clients to change their FTP password because of the @ sign in it. However, I have no idea on how to fix this - this issue is with more then B3 - the same issue occurs if you try to use a browser for FTP access.

What was your fix for source? Maybe there can be some"comment" entered so it will take it?

[Garreth]

My fix was a bit "brutal" I've changed the line 288 of status.py from:

Code:

ftp=FTP(self._ftpinfo['host'],self._ftpinfo['user'],passwd=self._ftpinfo['password'])

To:

Code:

ftp=FTP('ftphost','username@something','password')

But every time BBB gets updated I have to manually change this again... And as I said, I can't change the ftp username so that it won't contain "@".

[MordyT]

Quick noob question - if you try (in status.xml)

Code:

ftp://'username@something':password@host/path/you/want/it.xml

does that work? Notice the '

[Garreth]

I believe I tried doing it this way with no luck... The function which parses the URL probably needs to be changed.

[xlr8or]

When testing this dns in our function:

Code:

ftp://username@something:password@host/path/you/want/it.xml

the result is:

Code:

{u'protocol': u'ftp', u'host': u'host', u'user': u'username@something', u'path': u'/path/you/want/it.xml', u'password': u'password', u'port': None}

You see it recognizes: username@something as a valid username

But using pass@word (with @ in it) will fail tho:

Code:

{u'protocol': u'ftp', u'host': u'word@host', u'user': u'username@something', u'path': u'/path/you/want/it.xml', u'password': u'pass', u'port': None}

password: pass
host: word@host

For now don't accept @ in passwords since it will get parsed wrongly. Perhaps we can fix it in a later version

[Garreth]

I'll try it for you while upgrading BBB to 1.7.0 on my main server. But as far as I remember, something was wrong with it, but it could be random ftp server error...