next »

[Megak]

So I'm making a plugin that will ban by IPs and I'm getting messed up in my code inserting the banned ips into the SQL table I created. This is the code I have so far, the command works but SQL doesn't.

    def cmd_ipban(self, data, client=None, cmd=None):
   input = self._adminPlugin.parseUserCmd(data)
   cursor = self.console.storage.query( "INSERT INTO ippens VALUES (0,%s)" % input[0])
   cursor.close()

Thank you!

[Courgette]

you are not telling what the error message is

[Megak]

you are not telling what the error message is

i get a warning, can't handle func or something like that. the important thing is that the command looks like it works except nothing shows up when i look in the sql browser

[Courgette]

this is not helping much. maybe post your full plugin

[Megak]

I'll upload it when I get on my pc, but from eyeballing it, can you see any mistakes with the query line?

[Courgette]

it looks all right (as any not working code by the way). That's why context and error messages are important.

If you can't still see what's wrong by looking at the code, then run your code with a debugger (Eclipse pydev has an easy one to use)

[Megak]

Here's the full code. If you need the SQL create statement too, I can give that

Code: python

#Set the command level on line 21. Should be fairly obvious.

__version__ = 'infinity.0'
__author__  = 'Megak'

import b3
import b3.events
# Import the necessary libaries you need here, for example, I need random for the randomization of answers part of it.

#--------------------------------------------------------------------------------------------------
#This lot doesn't need to be changed for simple commands, it gets the admin plugin and registers commands.
class MegakPlugin(b3.plugin.Plugin):
    _adminPlugin = None
    requiresConfigFile = False

    def onStartup(self):  
        self._adminPlugin = self.console.getPlugin('admin')  
        if not self._adminPlugin:  
            return False  
        #SET COMMAND LEVEL HERE
        self._adminPlugin.registerCommand(self, 'getip', 90, self.cmd_getip)
        self._adminPlugin.registerCommand(self, 'banip', 90, self.cmd_ipban)


        self.registerEvent(b3.events.EVT_CLIENT_SAY)  
        self.registerEvent(b3.events.EVT_CLIENT_TEAM_SAY)  
        self.registerEvent(b3.events.EVT_CLIENT_AUTH)  
        self.registerEvent(b3.events.EVT_CLIENT_CONNECT)
  
        def onEvent(self, event):
            """\
            Handle intercepted events
            """
            if event.type == b3.events.EVT_CLIENT_CONNECT:
                cursor = self.console.storage.query( "SELECT * FROM ippens WHERE ip= %s" % event.client.ip)
                if cursor.rowcount >=1:
                    self.console.kick(event.client.cid, "Banned IP", None, True)
                cursor.close()


    def cmd_getip(self, data, client=None, cmd=None):
	input = self._adminPlugin.parseUserCmd(data)
	cursor = self.console.storage.query( "SELECT ip, name FROM clients WHERE id= %s" % input[0])
	r = cursor.getRow()
	client.message('%s IP: %s' % (r['name'], r['ip']))
	cursor.close()

    def cmd_ipban(self, data, client=None, cmd=None):
	input = self._adminPlugin.parseUserCmd(data)
	cursor = self.console.storage.query( "INSERT INTO ippens VALUES (0,%s)" % input[0])
	cursor.close()

[Courgette]

probably because an IP is a string and as such needs to be wrapped with quotes in your SQL statement. Try

Code: python

"SELECT * FROM ippens WHERE ip= '%s'" % event.client.ip

[Megak]

But that should be regardless of the insert command, right?

[Courgette]

I don't get what you mean, sorry :s

Try your sql queries in phpmyadmin or MySQL Workbench before you use them in your code, it will save you time.