next »

[Leito]

Hey guys! My plugin relies heavily on the accuracy of b3.team. If I have to restart B3 for maintenance, and there are players already on the server, B3 does not recognize the players on the server's teams. Is there any way I can rehash the connected players' teams on B3 start?

Thanks,
Leito

[Courgette]

Hi Leito,

try iourt41.py v1.11.3  that you can find on my github repo : https://github.com/courgette/big-brother-bot/raw/79fc3bc7374c4de71986f957835529efb2e80040/b3/parsers/iourt41.py
it has a better way of recoginizing teams when B3 starts and should help your plugin.

Please report any progress/issue with this new code.

[Courgette]

I've updated further the above code. See https://github.com/courgette/big-brother-bot/blob/4748b133217b87b6e2e64cb1a01564a50b40c45f/b3/parsers/iourt41.py for latest

[Leito]

Awesome thank you! It seems to be running well on my dev server. I'll move it over to the public server tomorrow and let you know how it works out. I've gotta finish this college application essay by tonight!  

Unrelated: Also, should the --InitGame-- and --InitRound-- game log statements both trigger EVT_GAME_ROUND_START? It seems as if InitGame is better as a separate event, especially if you are using ROUND_START to cue rcon commands on the start of TeamSurvivor rounds. B3 sends rcon commands to clients loading the map (because InitGame triggers the ROUND_START event) and sometimes causes clients to be dropped with the 'A reliable command was cycled out' message. InitGame is the beginning of a new map. InitRound is the beginning of a Team Survivor round. I think they should be separated. Thoughts?

[Garreth]

Also I'm not reporting any issues so far with the new parser.

[WickedShell]

I don't have a server to test this with at the moment, but when I looked at the changelog for the parser I noticed you renamed the local variable map to map_name, but then immediately do an if map: rather then if map_name:

That's only an error if map is not a global, and I'm not overly familiar with the internals of B3 python stuff, but I think that if needs to be renamed?

[Courgette]

I don't have a server to test this with at the moment, but when I looked at the changelog for the parser I noticed you renamed the local variable map to map_name, but then immediately do an if map: rather then if map_name:

Good catch! thank you for doing a code review.
Latest parser is now : https://github.com/courgette/big-brother-bot/blob/e3f49617893ce9da38c93da9ac40cfcdc708cf80/b3/parsers/iourt41.py

That's only an error if map is not a global, and I'm not overly familiar with the internals of B3 python stuff, but I think that if needs to be renamed?

map is a python reserved name. If you open up a python shell and type :

Code: python

type(map)

, python answers with

Code:

<type 'builtin_function_or_method'>

. So using 'map' for a local variable is bad practice as it overrides the builtin map function in the current scope. In the parser it was not actually an issue as we were not using the map() function in that scope, but one should fix bad practice when it sees it

[WickedShell]

Totally forgot about map being a built in, I know just enough python to get myself into trouble. Fixing bad practice is never a bad thing! Glad I could be of assistance.

[Courgette]

Unrelated: Also, should the --InitGame-- and --InitRound-- game log statements both trigger EVT_GAME_ROUND_START? It seems as if InitGame is better as a separate event, especially if you are using ROUND_START to cue rcon commands on the start of TeamSurvivor rounds. B3 sends rcon commands to clients loading the map (because InitGame triggers the ROUND_START event) and sometimes causes clients to be dropped with the 'A reliable command was cycled out' message. InitGame is the beginning of a new map. InitRound is the beginning of a Team Survivor round. I think they should be separated. Thoughts?

I guess it was made this way to accommodate game mods having no round (FFA I guess) so in such game mods plugins relying on the EVT_GAME_ROUND_START event can still know the game started.
What about modifying the OnInitgame game event handler so that it triggers a EVT_GAME_ROUND_START event only for game mods having no rounds ? (and for that we need a exhaustive list of such game mods)